refactor(share): remake the share chooser #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
force-pushed
the
andyholmes/ui
branch
3 times, most recently
from
fd67559 to
73452e6
Compare
andyholmes
force-pushed
the
andyholmes/ui
branch
from
73452e6 to
c0a29db
Compare
andyholmes
force-pushed
the
andyholmes/ui
branch
4 times, most recently
from
1f08030 to
65b17a7
Compare
andyholmes
force-pushed
the
andyholmes/ui
branch
from
65b17a7 to
e772ce5
Compare
andyholmes
force-pushed
the
andyholmes/ui
branch
from
e772ce5 to
24f3ba3
Compare
andyholmes
force-pushed
the
andyholmes/ui
branch
2 times, most recently
from
7c88495 to
4fc4a30
Compare
Rename `ValentShareTargetChooser` to `ValentShareDialog` and port to `AdwToolbarView` and other toolkit updates. Allow using the chooser for initiating sharing from the main window, as well as handling `GApplication::open` events.
andyholmes
force-pushed
the
andyholmes/ui
branch
from
4fc4a30 to
343588f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
ValentShareTargetChoosertoValentShareDialogand port toAdwToolbarViewand other toolkit updates.Allow using the chooser for initiating sharing from the main window, as
well as handling
GApplication::openevents.closes #574